[py] Call service.stop() when session can't be started #15636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
cgoldberg
force-pushed
the
py-stop-session-not-created
branch
from
0d751ff to
27c9166
Compare
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
This is a fix for #15634 (for Python only)
💥 What does this PR do?
When a driver fails to start the browser,
SessionNotCreatedExceptionis raised. This PR fixes it so the underlying driver service is explicitly stopped when any exception occurs.I added tests for this for Chrome, Edge, and Firefox
🔄 Types of changes
PR Type
Bug fix
Description
Ensures
service.stop()is called when session creation fails.Adds exception handling for
Exceptioninstart_session.Adds tests for this
Changes walkthrough 📝
webdriver.py
Add exception handling for session creation failurepy/selenium/webdriver/remote/webdriver.py
SessionNotCreatedExceptioninstart_session.service.stop()is called when session creation fails.